linux-kernel - Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201810090846.it9ed9td%fengguang.wu@intel.com>
Date:   Tue, 9 Oct 2018 08:47:26 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Pascal PAILLET-LME <p.paillet@...com>
Cc:     kbuild-all@...org,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "benjamin.gaignard@...aro.org" <benjamin.gaignard@...aro.org>,
        "eballetbo@...il.com" <eballetbo@...il.com>,
        Pascal PAILLET-LME <p.paillet@...com>
Subject: Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver

Hi pascal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.19-rc7 next-20181008]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pascal-PAILLET-LME/Introduce-STPMIC1-PMIC-Driver/20181009-042808
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All warnings (new ones prefixed by >>):

   In file included from drivers/watchdog/stpmic1_wdt.c:10:
   drivers/watchdog/stpmic1_wdt.c: In function 'pmic_wdt_stop':
>> drivers/watchdog/stpmic1_wdt.c:48:33: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551614' to '4294967294' [-Woverflow]
          WCHDG_CR, WDT_START_MASK, ~WDT_START);
   include/linux/regmap.h:77:42: note: in definition of macro 'regmap_update_bits'
     regmap_update_bits_base(map, reg, mask, val, NULL, false, false)
                                             ^~~

vim +48 drivers/watchdog/stpmic1_wdt.c

     4	
     5	#include <linux/kernel.h>
     6	#include <linux/mfd/stpmic1.h>
     7	#include <linux/module.h>
     8	#include <linux/platform_device.h>
     9	#include <linux/of.h>
  > 10	#include <linux/regmap.h>
    11	#include <linux/slab.h>
    12	#include <linux/watchdog.h>
    13	
    14	/* WATCHDOG CONTROL REGISTER bit */
    15	#define WDT_START		BIT(0)
    16	#define WDT_PING		BIT(1)
    17	#define WDT_START_MASK		BIT(0)
    18	#define WDT_PING_MASK		BIT(1)
    19	
    20	#define PMIC_WDT_MIN_TIMEOUT 1
    21	#define PMIC_WDT_MAX_TIMEOUT 256
    22	#define PMIC_WDT_DEFAULT_TIMEOUT 30
    23	
    24	static bool nowayout = WATCHDOG_NOWAYOUT;
    25	module_param(nowayout, bool, 0);
    26	MODULE_PARM_DESC(nowayout,
    27			"Watchdog cannot be stopped once started (default="
    28					__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
    29	
    30	struct stpmic1_wdt {
    31		struct stpmic1 *pmic;
    32		struct watchdog_device wdtdev;
    33	};
    34	
    35	static int pmic_wdt_start(struct watchdog_device *wdd)
    36	{
    37		struct stpmic1_wdt *wdt = watchdog_get_drvdata(wdd);
    38	
    39		return regmap_update_bits(wdt->pmic->regmap,
    40					  WCHDG_CR, WDT_START_MASK, WDT_START);
    41	}
    42	
    43	static int pmic_wdt_stop(struct watchdog_device *wdd)
    44	{
    45		struct stpmic1_wdt *wdt = watchdog_get_drvdata(wdd);
    46	
    47		return regmap_update_bits(wdt->pmic->regmap,
  > 48					  WCHDG_CR, WDT_START_MASK, ~WDT_START);
    49	}
    50	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (54978 bytes)