linux-kernel - Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin /

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181009075230.aaxne3z247yc3lu6@qschulz>
Date:   Tue, 9 Oct 2018 09:52:30 +0200
From:   Quentin Schulz <quentin.schulz@...tlin.com>
To:     Frieder Schrempf <frieder.schrempf@...eet.de>
Cc:     Maxime Ripard <maxime.ripard@...tlin.com>,
        Hans de Goede <hdegoede@...hat.com>,
        quentin.schulz@...e-electrons.com, ulf.hansson@...aro.org,
        gregkh@...uxfoundation.org, linus.walleij@...aro.org,
        shawn.lin@...k-chips.com, adrian.hunter@...el.com,
        baolin.wang@...aro.org, thomas.petazzoni@...e-electrons.com,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        devel@...verdev.osuosl.org, icenowy@...c.xyz, wens@...e.org
Subject: Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end
 functions

Hi Frieder,

On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote:
> Hi,
> 
> On 27.09.2018 10:14, Maxime Ripard wrote:
> > On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote:
> > > On 26-09-18 16:44, Frieder Schrempf wrote:
> > > > Hi,
> > > > 
> > > > On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote:
> > > > > [...]
> > > > > 
> > > > > > > > I'd like to know if any progress has been made on that problem
> > > > (I may
> > > > > > > > have missed patches).
> > > > > > > > Had you had the time to look at the issue?
> > > > > > > 
> > > > > > > I have looked at the issue, but not manage to cook some patches
> > > > for it.
> > > > > > > 
> > > > > > > However, it's on my top of my TODO list for mmc. No promises, but
> > > > > > > perhaps and hopefully I manage to get something posted during the
> > > > > > > coming release cycle.
> > > > 
> > > > I would be interested in a ESP8089 driver in mainline and that's why I want to pick up this discussion.
> > > > 
> > > > What is the current status of the "mmc_reprobe_device" implementation, that Hans was explaining and Ulf wanted to provide some months ago?
> > > 
> > > Ulf did eventually write a new way to deal with this and then Quentin
> > > did manage to get the esp8089 driver to work with it, the new function
> > > to use for this is added by this commit:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/core?id=1433269c4d2461be1f36db5dbb453976b38996ff
> > > 
> > > I'm not sure what the status of upstreaming the ep8089 driver is now
> > > that we've this in place.
> > > 
> > > Quentin, do you have a version of the esp8089 driver somewhere
> > > which will work correctly with the new mmc_sw_reset() function?
> > > 
> > > Also what is the status of adding this driver to say staging?
> > 
> > IIRC, we tried to get it into staging, and we got told that it was too
> > nice for staging at this point. So we're basically stuck somewhere
> > between staging and !staging, with the driver being too nice for the
> > former, and not nice enough for the latter :)
> 
> Ok, and is there someone willing to continue upstreaming the driver? Maybe
> someone can rebase and resend the latest approach?
> 
> After all it looks like a lot of work has already been done.
> 

There's clean up to do. It's time consuming but shouldn't be too hard to
do.

Then, we stressed the driver with an iperf test and it crashes very
often so we first need to identify if it happened with the "original"
driver before Icenowy's, Hans's and my clean-up. If it happened, since
we don't have a datasheet, it might be not that easy to fix. If it
didn't happen, then we have to find out where I cleaned up too much :D

I'm not currently working on this topic so anyone willing to take over
the work is free to do so.

Thanks,
Quentin

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)