linux-kernel - Re: [PATCH v4 3/3] infiniband/mm: convert put_page() to put_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Oct 2018 17:52:57 +0800
From:   kbuild test robot <lkp@...el.com>
To:     john.hubbard@...il.com
Cc:     kbuild-all@...org, Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...nel.org>,
        Christopher Lameter <cl@...ux.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Dan Williams <dan.j.williams@...el.com>,
        Jan Kara <jack@...e.cz>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org, John Hubbard <jhubbard@...dia.com>,
        Doug Ledford <dledford@...hat.com>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Christian Benvenuti <benve@...co.com>
Subject: Re: [PATCH v4 3/3] infiniband/mm: convert put_page() to
 put_user_page*()

Hi John,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.19-rc7 next-20181008]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/get_user_pages-and-RDMA-first-steps/20181009-152159
config: x86_64-randconfig-s4-10091707 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/qib/qib_user_sdma.c: In function 'qib_user_sdma_init_frag':
>> drivers/infiniband/hw/qib/qib_user_sdma.c:269:24: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
     pkt->addr[i].put_page = put_user_page;
                           ^

vim +269 drivers/infiniband/hw/qib/qib_user_sdma.c

   257	
   258	static void qib_user_sdma_init_frag(struct qib_user_sdma_pkt *pkt,
   259					    int i, u16 offset, u16 len,
   260					    u16 first_desc, u16 last_desc,
   261					    u16 put_page, u16 dma_mapped,
   262					    struct page *page, void *kvaddr,
   263					    dma_addr_t dma_addr, u16 dma_length)
   264	{
   265		pkt->addr[i].offset = offset;
   266		pkt->addr[i].length = len;
   267		pkt->addr[i].first_desc = first_desc;
   268		pkt->addr[i].last_desc = last_desc;
 > 269		pkt->addr[i].put_page = put_user_page;
   270		pkt->addr[i].dma_mapped = dma_mapped;
   271		pkt->addr[i].page = page;
   272		pkt->addr[i].kvaddr = kvaddr;
   273		pkt->addr[i].addr = dma_addr;
   274		pkt->addr[i].dma_length = dma_length;
   275	}
   276	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27331 bytes)