linux-kernel - Re: [PATCH] phy: inno-usb2-phy: fix off-by-one comparison on port number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAQ0ZWTOo8xr22f+kmeY+mrhGKgacCfCTaqO=zEewLuWGWvDYw@mail.gmail.com>
Date:   Tue, 9 Oct 2018 18:31:15 +0800
From:   Shawn Guo <shawn.guo@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Jiancheng Xue <xuejiancheng@...ilicon.com>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: inno-usb2-phy: fix off-by-one comparison on port number

On Tue, Oct 9, 2018 at 6:24 AM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently the range check on the port index is off-by-one and a potential
> out of bounds write can occur on priv->ports[i]. Fix this by checking the
> maximum port using >= INNO_PHY_PORT_NUM rather than > INNO_PHY_PORT_NUM.
>
> Detected by CoverityScan, CID#1466118 ("Out-of-bounds write")
>
> Fixes: ba8b0ee81fbb ("phy: add inno-usb2-phy driver for hi3798cv200 SoC")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Shawn Guo <shawn.guo@...aro.org>