linux-kernel - Re: [RFC][PATCH 1/3] printk: keep kernel cont support always enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181009124142.GC471@tigerII.localdomain>
Date:   Tue, 9 Oct 2018 21:41:42 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dmitriy Vyukov <dvyukov@...gle.com>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Tejun Heo <tj@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [RFC][PATCH 1/3] printk: keep kernel cont support always enabled

On (10/09/18 10:14), Petr Mladek wrote:
> Just to be sure. The original purpose was to get full information
> including the metadata and dictionary via extended console drivers,
> see commit 6fe29354befe4c46e ("printk: implement support for extended
> console drivers").

Right.

> IMHO, only the dictionary was really important but it was actually
> lost:
> 
>   static void cont_flush(void)
>   {
>   [...]
> 	log_store(cont.facility, cont.level, cont.flags, cont.ts_nsec,
> 		  NULL, 0, cont.buf, cont.len);
> 
> Nobody noticed because the only dictionary user is dev_printk()
> and dev_cont() is _not_ defined.

Right.

> As a result, I think that this change will rather improve things.
> Well, I wonder if we should write something of the above into
> the commit message. Either way:

The commit message probably can be improved, agreed.

> Reviewed-by: Petr Mladek <pmladek@...e.com>

Thanks.

	-ss