lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Oct 2018 15:56:52 +0200 From: Petr Mladek <pmladek@...e.com> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Geert Uytterhoeven <geert+renesas@...der.be>, "Tobin C. Harding" <me@...in.cc>, Andrew Morton <akpm@...ux-foundation.org>, Jonathan Corbet <corbet@....net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:DOCUMENTATION" <linux-doc@...r.kernel.org> Subject: Re: [PATCH 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id() On Mon 2018-10-08 16:37:29, Geert Uytterhoeven wrote: > Hi Andy, > > On Mon, Oct 8, 2018 at 4:25 PM Andy Shevchenko > <andriy.shevchenko@...ux.intel.com> wrote: > > On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote: > > > - Make the ptr argument const, to avoid adding casts in future > > > callers, > > > > > - Add a forward declaration, to avoid moving large blocks of code. > > > > How big it would be? ptr_to_id() itself plus... > > ... all the randomization helpers. > And ptr_to_id() needs pointer_string(), string(), widen_string(), number(), > and move_right(). > > 118 insertions(+), 120 deletions(-) > > Is that acceptable? Yes, it is acceptable. And my feeling is that it is the preferred solution is kernel because it helps to keep the code cleaner in the long term. I am for moving the code if there is no cyclic dependency. Best Regards, Petr
Powered by blists - more mailing lists