linux-kernel - [PATCH] lib: memcmp optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  9 Oct 2018 16:28:11 +0200
From:   Jack Wang <xjtuwjp@...il.com>
To:     gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
        florian-ewald.mueller@...fitbricks.com,
        linux-kernel@...r.kernel.org
Cc:     Jack Wang <jinpu.wang@...fitbricks.com>
Subject: [PATCH] lib: memcmp optimization

From: Florian-Ewald Mueller <florian-ewald.mueller@...fitbricks.com>

During testing, I have configured 128 md/raid1's and, while under
heavy IO, I started a check on each of them
(echo check > /sys/block/mdx/md/sync_action).

The CPU utilization went through the ceiling and when looking for
the cause (with 'perf top'). I've discovered that ~50% of the time
was spend in memcmp() called from process_checks().

With this patch applied, it drops to 4% - 10%.

Signed-off-by: Florian-Ewald Mueller <florian-ewald.mueller@...fitbricks.com>
[jwang: reformat the commit message]
Signed-off-by: Jack Wang <jinpu.wang@...fitbricks.com>
---
 lib/string.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/lib/string.c b/lib/string.c
index 2c0900a5d51a..932ef9af2baa 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -852,7 +852,7 @@ EXPORT_SYMBOL(memmove);
  * @count: The size of the area.
  */
 #undef memcmp
-__visible int memcmp(const void *cs, const void *ct, size_t count)
+static inline int __memcmp(const void *cs, const void *ct, size_t count)
 {
 	const unsigned char *su1, *su2;
 	int res = 0;
@@ -862,6 +862,20 @@ __visible int memcmp(const void *cs, const void *ct, size_t count)
 			break;
 	return res;
 }
+__visible int memcmp(const void *cs, const void *ct, size_t count)
+{
+	const uint64_t *l1p = cs;
+	const uint64_t *l2p = ct;
+
+	while (count >= sizeof(*l1p)) {
+		if (*l1p != *l2p)
+			return __memcmp(l1p, l2p, sizeof(*l1p));
+		count -= sizeof(*l1p);
+		++l1p;
+		++l2p;
+	}
+	return __memcmp(l1p, l2p, count);
+}
 EXPORT_SYMBOL(memcmp);
 #endif
 
-- 
2.7.4