lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 10 Oct 2018 13:19:48 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Filippo Sironi <sironi@...zon.de>
Cc:     kbuild-all@...org, sironi@...zon.de, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: Start populating /sys/hypervisor with KVM entries

Hi Filippo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux-sof-driver/master]
[also build test ERROR on v4.19-rc7 next-20181009]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Filippo-Sironi/KVM-Start-populating-sys-hypervisor-with-KVM-entries/20181010-064236
base:   https://github.com/thesofproject/linux master
config: powerpc64-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc64 

All error/warnings (new ones prefixed by >>):

   In file included from arch/powerpc/include/uapi/asm/kvm_para.h:82:0,
                    from arch/powerpc/include/asm/kvm_para.h:22,
                    from drivers//kvm/sys-hypervisor.c:3:
>> arch/powerpc/include/asm/epapr_hcalls.h:109:12: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'epapr_paravirt_early_init'
    int __init epapr_paravirt_early_init(void);
               ^~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/powerpc/include/asm/epapr_hcalls.h:53:0,
                    from arch/powerpc/include/uapi/asm/kvm_para.h:82,
                    from arch/powerpc/include/asm/kvm_para.h:22,
                    from drivers//kvm/sys-hypervisor.c:3:
   arch/powerpc/include/asm/kvm_para.h: In function 'kvm_arch_para_features':
>> arch/powerpc/include/asm/kvm_para.h:58:40: error: 'KVM_HC_FEATURES' undeclared (first use in this function); did you mean 'KVM_HCALL_TOKEN'?
     if(epapr_hypercall0_1(KVM_HCALL_TOKEN(KVM_HC_FEATURES), &r))
                                           ^
   arch/powerpc/include/uapi/asm/epapr_hcalls.h:75:51: note: in definition of macro '_EV_HCALL_TOKEN'
    #define _EV_HCALL_TOKEN(id, num) (((id) << 16) | (num))
                                                      ^~~
>> arch/powerpc/include/asm/kvm_para.h:58:24: note: in expansion of macro 'KVM_HCALL_TOKEN'
     if(epapr_hypercall0_1(KVM_HCALL_TOKEN(KVM_HC_FEATURES), &r))
                           ^~~~~~~~~~~~~~~
   arch/powerpc/include/asm/kvm_para.h:58:40: note: each undeclared identifier is reported only once for each function it appears in
     if(epapr_hypercall0_1(KVM_HCALL_TOKEN(KVM_HC_FEATURES), &r))
                                           ^
   arch/powerpc/include/uapi/asm/epapr_hcalls.h:75:51: note: in definition of macro '_EV_HCALL_TOKEN'
    #define _EV_HCALL_TOKEN(id, num) (((id) << 16) | (num))
                                                      ^~~
>> arch/powerpc/include/asm/kvm_para.h:58:24: note: in expansion of macro 'KVM_HCALL_TOKEN'
     if(epapr_hypercall0_1(KVM_HCALL_TOKEN(KVM_HC_FEATURES), &r))
                           ^~~~~~~~~~~~~~~

vim +58 arch/powerpc/include/asm/kvm_para.h

bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  21  
c3617f72 arch/powerpc/include/asm/kvm_para.h David Howells    2012-10-09 @22  #include <uapi/asm/kvm_para.h>
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  23  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  24  #ifdef CONFIG_KVM_GUEST
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  25  
26e673c3 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-09-03  26  #include <linux/of.h>
26e673c3 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-09-03  27  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  28  static inline int kvm_para_available(void)
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  29  {
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  30  	struct device_node *hyper_node;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  31  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  32  	hyper_node = of_find_node_by_path("/hypervisor");
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  33  	if (!hyper_node)
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  34  		return 0;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  35  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  36  	if (!of_device_is_compatible(hyper_node, "linux,kvm"))
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  37  		return 0;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  38  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  39  	return 1;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  40  }
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  41  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  42  #else
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  43  
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  44  static inline int kvm_para_available(void)
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  45  {
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  46  	return 0;
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  47  }
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  48  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  49  #endif
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  50  
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  51  static inline unsigned int kvm_arch_para_features(void)
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  52  {
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  53  	unsigned long r;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  54  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  55  	if (!kvm_para_available())
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  56  		return 0;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  57  
b1f0d94c arch/powerpc/include/asm/kvm_para.h Bharat Bhushan   2013-10-08 @58  	if(epapr_hypercall0_1(KVM_HCALL_TOKEN(KVM_HC_FEATURES), &r))
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  59  		return 0;
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  60  
2a342ed5 arch/powerpc/include/asm/kvm_para.h Alexander Graf   2010-07-29  61  	return r;
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  62  }
bbf45ba5 include/asm-powerpc/kvm_para.h      Hollis Blanchard 2008-04-16  63  

:::::: The code at line 58 was first introduced by commit
:::::: b1f0d94c26b64e814243b736f47e7ef40d96432c kvm/powerpc: move kvm_hypercall0() and friends to epapr_hypercall0()

:::::: TO: Bharat Bhushan <r65777@...escale.com>
:::::: CC: Alexander Graf <agraf@...e.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (56064 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ