linux-kernel - Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Oct 2018 10:27:20 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Quentin Schulz <quentin.schulz@...tlin.com>
Cc:     linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in
 vsc8574_config_pre_init

Hey Quentin,

On 10/10/18 8:49 AM, Quentin Schulz wrote:

>>  
>>  out:
>>  	phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
>> -
>> +release_fw:
>>  	release_firmware(fw);
> 
> You can reuse the out goto label instead, I would like all functions in
> the driver to exit with the PHY set to access the standard page.
> 

Oh okay. I've got it.

I'll send v2 shortly.

Thanks for the feedback.
--
Gustavo