linux-kernel - Re: [PATCH v2 15/23] ACPI: use proper DYNAMIC_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Oct 2018 11:38:29 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     jbaron@...mai.com, Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v2 15/23] ACPI: use proper DYNAMIC_DEBUG_BRANCH macro

On Tue, Oct 9, 2018 at 1:21 PM Rasmus Villemoes
<linux@...musvillemoes.dk> wrote:
>
> dynamic debug may be implemented via static keys, but ACPI is missing
> out on that runtime benefit since it open-codes one possible definition
> of DYNAMIC_DEBUG_BRANCH.
>
> Cc: linux-acpi@...r.kernel.org
> Acked-by: Jason Baron <jbaron@...mai.com>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  include/linux/acpi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index de8d3d3fa651..21e03aa32aae 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -982,7 +982,7 @@ void __acpi_handle_debug(struct _ddebug *descriptor, acpi_handle handle, const c
>  #define acpi_handle_debug(handle, fmt, ...)                            \
>  do {                                                                   \
>         DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);                 \
> -       if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT))          \
> +       if (DYNAMIC_DEBUG_BRANCH(descriptor))                           \
>                 __acpi_handle_debug(&descriptor, handle, pr_fmt(fmt),   \
>                                 ##__VA_ARGS__);                         \
>  } while (0)
> --
> 2.19.1.3.g1d92a00e68
>