[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Oct 2018 15:01:29 +0200
From: Andreas Schwab <schwab@...e.de>
To: Atish Patra <atish.patra@....com>
Cc: palmer@...ive.com, linux-riscv@...ts.infradead.org,
linux-pwm@...r.kernel.org, linux-gpio@...r.kernel.org,
linus.walleij@...aro.org, robh+dt@...nel.org,
thierry.reding@...il.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, mark.rutland@....com,
hch@...radead.org
Subject: Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs
On Okt 09 2018, Atish Patra <atish.patra@....com> wrote:
> +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset)
> +{
> + unsigned long flags;
> + unsigned int trigger;
> +
> + raw_spin_lock_irqsave(&chip->lock, flags);
> + trigger = (chip->enabled & BIT(offset)) ? chip->trigger[offset] : 0;
This should use test_bit instead.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@...e.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Powered by blists - more mailing lists