linux-kernel - Re: [PATCH 1/6] usb: uvc: include videodev2.h in g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Oct 2018 16:42:51 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Paul Elder <paul.elder@...asonboard.com>
Cc:     kieran.bingham@...asonboard.com, b-liu@...com,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, balbi@...nel.org,
        stern@...land.harvard.edu, rogerq@...com
Subject: Re: [PATCH 1/6] usb: uvc: include videodev2.h in g_uvc.h

Hi Paul,

Thank you for the patch.

On Wednesday, 10 October 2018 05:48:58 EEST Paul Elder wrote:
> V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in
> videodev2.h, which is not included and causes a compiler warning:
> 
> linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undeclared here
> (not in a function) #define UVC_EVENT_FIRST   (V4L2_EVENT_PRIVATE_START +
> 0)
> 
> Include videodev2.h in g_uvc.h.
> 
> Signed-off-by: Paul Elder <paul.elder@...asonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

This is independent of the rest of the series so I've taken it in my tree 
already, with the subject line modified to use "usb: gadget: uvc:" as a 
prefix.

> ---
>  include/uapi/linux/usb/g_uvc.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/usb/g_uvc.h b/include/uapi/linux/usb/g_uvc.h
> index 3c9ee3020cbb..6698c3263ae8 100644
> --- a/include/uapi/linux/usb/g_uvc.h
> +++ b/include/uapi/linux/usb/g_uvc.h
> @@ -11,6 +11,7 @@
>  #include <linux/ioctl.h>
>  #include <linux/types.h>
>  #include <linux/usb/ch9.h>
> +#include <linux/videodev2.h>
> 
>  #define UVC_EVENT_FIRST			(V4L2_EVENT_PRIVATE_START + 0)
>  #define UVC_EVENT_CONNECT		(V4L2_EVENT_PRIVATE_START + 0)

-- 
Regards,

Laurent Pinchart