linux-kernel - RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field instead of string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Oct 2018 13:59:36 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     James Nuss <jamesnuss@...ometrics.ca>
CC:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/7] mmc-utils: treat FIRMWARE_VERSION as binary field
 instead of string

> 
> On Wed, Oct 10, 2018 at 4:43 AM Avri Altman <Avri.Altman@....com> wrote:
> >
> >
> > > +++ b/mmc_cmds.c
> > > @@ -1758,8 +1758,15 @@ int do_read_extcsd(int nargs, char **argv)
> > >       }
> > >
> > >       if (ext_csd_rev >= 7) {
> > > -             printf("eMMC Firmware Version: %s\n",
> > > -                     (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]);
> > > +             printf("Firmware Version:
> > > 0x%02x%02x%02x%02x%02x%02x%02x%02x\n",
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_7],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_6],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_5],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_4],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_3],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_2],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_1],
> > > +                     ext_csd[EXT_CSD_FIRMWARE_VERSION_0]);
> > ExtCSD[261:254] is an ASCII string, just add a terminating null.
> 
> Unfortunately I found two different manufacturers which put
> non-printable characters in this 8-byte field. So I don't think it can
> be treated as ASCII in all cases. Printing out the hex value seemed
> liked the most comprehensive solution.
NAK with prejudice.
This interfere with the output that we/our clients expects.