[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 10 Oct 2018 08:06:38 -0600
From: Jason Gunthorpe <jgg@...pe.ca>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: Tomas Winkler <tomas.winkler@...el.com>,
Peter Huewe <peterhuewe@....de>,
Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: fix unused-value issues in tpm_try_transmit
On Wed, Oct 10, 2018 at 03:38:17PM +0200, Gustavo A. R. Silva wrote:
> Currently, there are some values assigned to variable *rc*, which
> are never actually used in any computation, because such variable
> is updated at line 550, before they can be used:
>
> 549out:
> 550 rc = tpm_go_idle(chip, flags);
> 551 if (rc)
> 552 goto out;
>
> Fix this by removing such assignments.
Should this be done by not quashing rc during the error unwind rather
than dropping the errors?
Jason
Powered by blists - more mailing lists