linux-kernel - Re: [PATCH v3] mfd: cros-ec: copy the whole event in get_next_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Oct 2018 22:06:33 -0700
From:   Benson Leung <bleung@...omium.org>
To:     Emil Karlson <jekarlson@...il.com>
Cc:     kernel@...il.dk, Neil Armstrong <narmstrong@...libre.com>,
        Stefan Adolfsson <sadolfsson@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Olof Johansson <olof@...om.net>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] mfd: cros-ec: copy the whole event in get_next_event_xfer

Hi Emil,
On Wed, Oct 3, 2018 at 11:43 AM Emil Karlson <jekarlson@...il.com> wrote:
>
> Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events
> be truncated on many chromebooks so that Left and Right keys on Column 12 were
> always 0. Use ret as memcpy len to fix this.
>
> The old code was using ec_dev->event_size, which is the event payload/data size
> excluding event_type header, for the length of the memcpy operation. Use ret
> as memcpy length to avoid the off by one and copy the whole msg->data.
>
> Fixes: 57e94c8b974d ("mfd: cros-ec: Increase maximum mkbp event size")
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Tested-by: Emil Renner Berthing <kernel@...il.dk>
> Signed-off-by: Emil Karlson <jekarlson@...il.com>

Applied. Sent to Greg for rc8, hopefully.



-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org