linux-kernel - Re: [PATCH v5 05/21] tpm: factor out tpm_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1539288758.1669.15.camel@intel.com>
Date:   Thu, 11 Oct 2018 20:16:34 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     "jarkko.sakkinen@...ux.intel.com" <jarkko.sakkinen@...ux.intel.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "nayna@...ux.ibm.com" <nayna@...ux.ibm.com>
CC:     "nayna@...ux.vnet.ibm.com" <nayna@...ux.vnet.ibm.com>,
        "Struk, Tadeusz" <tadeusz.struk@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 05/21] tpm: factor out tpm_get_timeouts()

On Thu, 2018-10-11 at 22:30 +0530, Nayna Jain wrote:
> 
> On 09/29/2018 04:00 AM, Tomas Winkler wrote:
> > 
> > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> > index 73511cd89bef..a97d72fcda5b 100644
> > --- a/drivers/char/tpm/tpm.h
> > +++ b/drivers/char/tpm/tpm.h
> > @@ -544,8 +544,10 @@ int tpm_startup(struct tpm_chip *chip);
> >   ssize_t tpm_getcap(struct tpm_chip *chip, u32 subcap_id, cap_t *cap,
> >   		   const char *desc, size_t min_cap_length);
> >   int tpm_get_timeouts(struct tpm_chip *);
> > -int tpm1_auto_startup(struct tpm_chip *chip);
> >   int tpm_do_selftest(struct tpm_chip *chip);
> > +
> > +int tpm1_auto_startup(struct tpm_chip *chip);
> 
> What is different in this tpm1_auto_startup(...) and the original one ?
> 
> Is this needed ?
Looks like an amending  hiccup, will fix.
Thanks
Tomas