linux-kernel - RE: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Oct 2018 21:22:50 +0000
From:   Alexey Brodkin <alexey.brodkin@...opsys.com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vineet Gupta <vineet.gupta1@...opsys.com>
Subject: RE: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs

Hu Guenter,

> -----Original Message-----
> From: linux-snps-arc [mailto:linux-snps-arc-bounces@...ts.infradead.org] On Behalf Of Guenter Roeck
> Sent: Wednesday, September 12, 2018 7:58 PM
> To: Vineet Gupta <vineet.gupta1@...opsys.com>
> Cc: linux-snps-arc@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] ARCv2: build: use mcpu=hs38 iso generic mcpu=archs
> 
> Hi,
> 
> On Fri, Sep 07, 2018 at 03:13:10PM -0700, Vineet Gupta wrote:
> > helps gcc with better instruction selections such as 64-bit multiply MPYD
> >
> > before
> > ------
> > 82c34b58 <sched_clock>:
> > 82c34b58:	ld	r2,[0x83068d00]
> > 82c34b60:	add_s	r2,r2,0x7530
> > 82c34b66:	mov_s	r0,0x989680
> > 82c34b6c:	mpymu	r5,r2,r0
> > 82c34b70:	mpy	r4,r2,r0
> > 82c34b74:	mov_s	r0,r4
> > 82c34b76:	j_s.d	[blink]
> > 82c34b78:	mov_s	r1,r5
> > 82c34b7a:	nop_s
> >
> > after
> > ------
> > 82c34b7c <sched_clock>:
> > 82c34b7c:	ld	r0,[0x83064d00]
> > 82c34b84:	add_s	r0,r0,0x7530
> > 82c34b8a:	mpydu	r0,r0,0x989680
> > 82c34b92:	j_s	[blink]
> >
> > Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
> 
> This patch causes my arc2 test builds to fail
> 
> Building arc:axs103_defconfig ... failed
> --------------
> Error log:
> 
> standard input}: Assembler messages:
> {standard input}:154: Error: inappropriate arguments for opcode 'st'
> {standard input}:157: Error: Insn j_s has a jump/branch instruction j_s in its delay slot.
> {standard input}:186: Error: inappropriate arguments for opcode 'st'
> make[3]: *** [net/core/dev.o] Error 1
> make[2]: *** [net/core] Error 2
> 
> Building arc:nsim_hs_smp_defconfig ... failed
> --------------
> Error log:
> {standard input}: Assembler messages:
> {standard input}:218: Error: inappropriate arguments for opcode 'st'
> {standard input}:9329: Error: inappropriate arguments for opcode 'st'
> 
> Building arc:vdk_hs38_smp_defconfig ... failed
> --------------
> Error log:
> 
> {standard input}: Assembler messages:
> {standard input}:9629: Error: inappropriate arguments for opcode 'st'
> {standard input}:9883: Error: inappropriate arguments for opcode 'st'
> 
> I use a toolchain based on gcc 7.3.0 and binutils 2.30. What version
> of gcc and binutils do I need for the builds to complete ?

I would strongly recommend to use GCC 8.2+ for ARC as there were
quite some improvements and fixes done for ARC.

You may use master branch of Crosstool-NG for building uClibc multilib toolchain
for ARC based on Binutils 2.31.1 and GCC 8.2.0.

Just say "./ct-ng arc-multilib-linux-uclibc" for that.
For me freshly-built tools were able to build Vineet's today's "for-curr" tree
with mentioned patch perfectly fine.

-Alexey