linux-kernel - Re: [PATCH] mfd: remove redundant 'default n' from Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181011054806.GS4939@dell>
Date:   Thu, 11 Oct 2018 06:48:06 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: remove redundant 'default n' from Kconfig

On Wed, 10 Oct 2018, Bartlomiej Zolnierkiewicz wrote:

> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
> 
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
> 
>     ...
>     One side effect of (and the main motivation for) this change is making
>     the following two definitions behave exactly the same:
>     
>         config FOO
>                 bool
>     
>         config FOO
>                 bool
>                 default n
>     
>     With this change, neither of these will generate a
>     '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
>     That might make it clearer to people that a bare 'default n' is
>     redundant.
>     ...
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> ---
>  drivers/mfd/Kconfig |    6 ------
>  1 file changed, 6 deletions(-)

The change looks okay to me, but I would also like you to include the
Maintainers/Reviewers for the affected source files.

Also, I assume you are not just submitting these changes to the MFD
subsystem.  My suggesting is to change each subsystem per patch (as
you have done here), and submit them in one patch-set with each of the
subsystem Maintainers included, so each of us has some visibility into
how the general idea is being received.

> Index: b/drivers/mfd/Kconfig
> ===================================================================
> --- a/drivers/mfd/Kconfig	2018-10-09 15:58:40.547122978 +0200
> +++ b/drivers/mfd/Kconfig	2018-10-10 16:49:37.575915230 +0200
> @@ -8,7 +8,6 @@ menu "Multifunction device drivers"
>  config MFD_CORE
>  	tristate
>  	select IRQ_DOMAIN
> -	default n
>  
>  config MFD_CS5535
>  	tristate "AMD CS5535 and CS5536 southbridge core functions"
> @@ -870,7 +869,6 @@ config MFD_VIPERBOARD
>          tristate "Nano River Technologies Viperboard"
>  	select MFD_CORE
>  	depends on USB
> -	default n
>  	help
>  	  Say yes here if you want support for Nano River Technologies
>  	  Viperboard.
> @@ -1575,7 +1573,6 @@ config MFD_TWL4030_AUDIO
>  	bool "TI TWL4030 Audio"
>  	depends on TWL4030_CORE
>  	select MFD_CORE
> -	default n
>  
>  config TWL6040_CORE
>  	bool "TI TWL6040 audio codec"
> @@ -1583,7 +1580,6 @@ config TWL6040_CORE
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
> -	default n
>  	help
>  	  Say yes here if you want support for Texas Instruments TWL6040 audio
>  	  codec.
> @@ -1605,7 +1601,6 @@ config MFD_WL1273_CORE
>  	tristate "TI WL1273 FM radio"
>  	depends on I2C
>  	select MFD_CORE
> -	default n
>  	help
>  	  This is the core driver for the TI WL1273 FM radio. This MFD
>  	  driver connects the radio-wl1273 V4L2 module and the wl1273
> @@ -1649,7 +1644,6 @@ config MFD_TC3589X
>  
>  config MFD_TMIO
>  	bool
> -	default n
>  
>  config MFD_T7L66XB
>  	bool "Toshiba T7L66XB"

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog