linux-kernel - Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181010.225447.2264091665828087261.davem@davemloft.net>
Date:   Wed, 10 Oct 2018 22:54:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     kishon@...com, quentin.schulz@...tlin.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check
 in serdes_probe()

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Wed, 10 Oct 2018 02:00:24 +0000

> In case of error, the function syscon_node_to_regmap() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot SerDes muxing")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied.