linux-kernel - Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1Kbxue2PXRL87-Saiotyq-+v=Uc3vL9KArRuLqCwC4bw@mail.gmail.com>
Date:   Thu, 11 Oct 2018 09:03:51 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Firoz Khan <firoz.khan@...aro.org>
Cc:     Helge Deller <deller@....de>,
        Parisc List <linux-parisc@...r.kernel.org>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        gregkh <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation

On Thu, Oct 11, 2018 at 8:48 AM Firoz Khan <firoz.khan@...aro.org> wrote:
> On Thu, 11 Oct 2018 at 11:40, Firoz Khan <firoz.khan@...aro.org> wrote:
> > On Wed, 10 Oct 2018 at 01:48, Helge Deller <deller@....de> wrote:

> > > +
> > > +ENTRY(sys_call_table)
> > > +#if defined(CONFIG_64BIT)
> > > +#include <asm/syscall_table_c32.h>     /* compat syscalls */
> > > +#else
> > > +#include <asm/syscall_table_32.h>      /* 32-bit native syscalls */
> > > +#endif
> > > +END(sys_call_table)
> > > +
> > >  #ifdef CONFIG_64BIT
> > > -#define SYSCALL_TABLE_64BIT
> > > -#include "syscall_table_64.S"
> > > +ENTRY(sys_call_table64)
> > > +#include <asm/syscall_table_64.h>      /* 64-bit native syscalls */
> > > +END(sys_call_table64)
> > >  #endif
> > >
> > >         /*
>
> I could see a patch (commit 47514da3ac20150cdf764466fbc2010c0fca0163)
> which will perform a compile-check when adding a new syscall. My patches
> will remove this feature. Is that fine?

I think it's ok: You are automating it so the bug can no longer happen,
which is better than adding checks to prevent human errors.

        Arnd