linux-kernel - Re: [PATCH v3 7/7] mfd: axp20x: Add supported cells for AXP803

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Oct 2018 16:10:12 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     oskari@...mela.net
Cc:     Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Lee Jones <lee.jones@...aro.org>,
        Quentin Schulz <quentin.schulz@...e-electrons.com>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 7/7] mfd: axp20x: Add supported cells for AXP803

On Tue, Oct 9, 2018 at 2:20 AM Oskari Lemmela <oskari@...mela.net> wrote:
>
> AXP803 is compatible with AXP813.
> Adding cells for GPIO, ADC, AC and battery power supplies.
>
> Signed-off-by: Oskari Lemmela <oskari@...mela.net>
> ---
>  drivers/mfd/axp20x.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 1508d9113126..4befe474b165 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -731,8 +731,23 @@ static const struct mfd_cell axp803_cells[] = {
>                 .name                   = "axp221-pek",
>                 .num_resources          = ARRAY_SIZE(axp803_pek_resources),
>                 .resources              = axp803_pek_resources,
> +       }, {
> +               .name                   = "axp20x-regulator",

Please keep this as one line as before. This was requested by the MFD
maintainer.

> +       }, {
> +               .name                   = "axp20x-gpio",
> +               .of_compatible          = "x-powers,axp813-gpio",

You might want to put the GPIO cell near the top of the list, so any other
users, such as the ADC and regulator cells, will probe after it.

> +       }, {
> +               .name                   = "axp813-adc",
> +               .of_compatible          = "x-powers,axp813-adc",
> +       }, {
> +               .name           = "axp20x-battery-power-supply",
> +               .of_compatible  = "x-powers,axp813-battery-power-supply",
> +       }, {
> +               .name           = "axp20x-ac-power-supply",
> +               .of_compatible  = "x-powers,axp813-ac-power-supply",
> +               .num_resources  = ARRAY_SIZE(axp20x_ac_power_supply_resources),
> +               .resources      = axp20x_ac_power_supply_resources,

Please use the same indentation.

Regards
ChenYu

>         },
> -       {       .name                   = "axp20x-regulator" },
>  };
>
>  static const struct mfd_cell axp806_self_working_cells[] = {
> --
> 2.17.1
>