linux-kernel - Re: [PATCH] staging: vboxvideo: make a couple of funcs static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08d278ea-516d-0c8a-a240-44d41af6063e@redhat.com>
Date:   Thu, 11 Oct 2018 10:53:43 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Craig Kewley <craigkewley@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sean Paul <seanpaul@...omium.org>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vboxvideo: make a couple of funcs static

Hi,

On 10-10-18 22:17, Craig Kewley wrote:
> Fix Sparse warnings:
> drivers/staging/vboxvideo/vbox_mode.c:309:6: warning:
> symbol 'vbox_primary_atomic_disable' was not declared. Should it be static?
> 
> drivers/staging/vboxvideo/vbox_mode.c:452:6: warning:
> symbol 'vbox_cursor_atomic_disable' was not declared. Should it be static?
> 
> Signed-off-by: Craig Kewley <craigkewley@...il.com>

Thanks.

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/staging/vboxvideo/vbox_mode.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index 042e4f384df9..deed28c7a1db 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -306,8 +306,8 @@ static void vbox_primary_atomic_update(struct drm_plane *plane,
>   				    plane->state->src_y >> 16);
>   }
>   
> -void vbox_primary_atomic_disable(struct drm_plane *plane,
> -				 struct drm_plane_state *old_state)
> +static void vbox_primary_atomic_disable(struct drm_plane *plane,
> +					struct drm_plane_state *old_state)
>   {
>   	struct drm_crtc *crtc = old_state->crtc;
>   
> @@ -449,8 +449,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
>   	mutex_unlock(&vbox->hw_mutex);
>   }
>   
> -void vbox_cursor_atomic_disable(struct drm_plane *plane,
> -				struct drm_plane_state *old_state)
> +static void vbox_cursor_atomic_disable(struct drm_plane *plane,
> +				       struct drm_plane_state *old_state)
>   {
>   	struct vbox_private *vbox =
>   		container_of(plane->dev, struct vbox_private, ddev);
>