linux-kernel - Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181011093234.GA2400@vkoul-mobl>
Date:   Thu, 11 Oct 2018 15:02:34 +0530
From:   Vinod <vkoul@...nel.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Shefali Jain <shefjain@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Anu Ramanathan <anur@...eaurora.org>,
        Taniya Das <tdas@...eaurora.org>,
        "open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>
Subject: Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver
 for QCS404

On 11-10-18, 00:19, Stephen Boyd wrote:
> Quoting Vinod (2018-10-07 20:51:44)
> > On 07-10-18, 19:38, Stephen Boyd wrote:
> > > Quoting Vinod (2018-10-02 23:21:03)
> > > > Hi Stephen,
> > > > 
> > > > Thanks for the comments,
> > > > 
> > > > On 01-10-18, 10:19, Stephen Boyd wrote:
> > > > > Quoting Vinod Koul (2018-09-21 11:59:36)
> > > > > > From: Shefali Jain <shefjain@...eaurora.org>
> > > > > > 
> > > > > > Add the clocks supported in global clock controller which clock the
> > > > > > peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks
> > > > > > to the clock framework for the clients to be able to request for them.
> > > > > > 
> > > > > > Signed-off-by: Shefali Jain <shefjain@...eaurora.org>
> > > > > > Signed-off-by: Taniya Das <tdas@...eaurora.org>
> > > > > > Co-developed-by: Taniya Das <tdas@...eaurora.org>
> > > > > > Signed-off-by: Anu Ramanathan <anur@...eaurora.org>
> > > > > > [rebase and tidyup for upstream]
> > > > > 
> > > > > Who did the tidying?
> > > > 
> > > > both of us :)
> > > 
> > > OK, please add the username of both people per the kernel sign off
> > > standards.
> > > 
> > > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > > > > > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > 
> > Sorry not sure I understand, Bjorn and me did cleanup and we signed-off
> > per process, did I miss something?
> 
> I mean doing something like:
> 
> [bjorn.andersson@...aro.org: Clean and tidy]
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> [vkoul@...nel.org: Clean and tidy even more]
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> 
> Would be the kernel standard for maintainer tags.

Ah I did:

[bamse, vkoul: rebase and tidyup for upstream]

I can wait for comments if you have for v2 and update and send v3
then?

> 
> > 
> > > > > > +       [GCC_USB_HS_PHY_CFG_AHB_CLK] = &gcc_usb_hs_phy_cfg_ahb_clk.clkr,
> > > > > > +       [GCC_USB_HS_SYSTEM_CLK] = &gcc_usb_hs_system_clk.clkr,
> > > > > > +       [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr,
> > > > > > +       [GP1_CLK_SRC] = &gp1_clk_src.clkr,
> > > > > 
> > > > > Why are some of these missing GCC_ prefix?
> > > > 
> > > > will add..
> > > 
> > > Thanks!
> > 
> > Btw Taniya also commented on this, do you want this as GCC_ or as per hw
> > documentation?
> 
> I don't care. Either way is fine with me.

I have used GCC_ :)

-- 
~Vinod