linux-kernel - Re: [PATCH v12 3/3]: perf record: extend trace writing to multi AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dedfcb0-f39a-7117-1b61-d0cac2fd1f1e@linux.intel.com>
Date:   Thu, 11 Oct 2018 19:14:03 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v12 3/3]: perf record: extend trace writing to multi AIO

Hi,
On 11.10.2018 16:45, Jiri Olsa wrote:
> On Tue, Oct 09, 2018 at 11:59:31AM +0300, Alexey Budankov wrote:
<SNIP>
> 
>> @@ -1886,8 +1917,8 @@ static struct option __record_options[] = {
>>  	OPT_BOOLEAN(0, "dry-run", &dry_run,
>>  		    "Parse options then exit"),
>>  #ifdef HAVE_AIO_SUPPORT
>> -	OPT_CALLBACK_NOOPT(0, "aio", &record.opts,
>> -		     NULL, "Enable asynchronous trace writing mode",
> 
> hum, why removing --aio option? I though we will have:
> 
>   perf record --aio ....           # enables aio with default settings
>   perf record --aio-cblocks=3 ...  # enabled aio with aio-cblocks=3

It is possible to avoid the complication using only one --aio option like this:

   perf record --aio ...    # enables aio with default (=1)
   perf record --aio=4 ...  # enables aio with parameter = 4

--aio-cblocks=4 still works when specified like --aio=4.

Thanks,
Alexey