linux-kernel - Re: [POC][RFC][PATCH 1/2] jump_function: Addition of new feature "jump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <B7EBEF5D-443E-4764-8589-DE470F93422D@amacapital.net>
Date:   Thu, 11 Oct 2018 09:20:40 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Matthew Helsley <mhelsley@...are.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Jason Baron <jbaron@...mai.com>, Jiri Kosina <jkosina@...e.cz>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andrew Lutomirski <luto@...nel.org>
Subject: Re: [POC][RFC][PATCH 1/2] jump_function: Addition of new feature "jump_function"



> On Oct 11, 2018, at 5:52 AM, Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> 
>> On Wed, Oct 10, 2018 at 10:07:38PM -0500, Josh Poimboeuf wrote:
>>> On Wed, Oct 10, 2018 at 02:13:22PM -0700, Andy Lutomirski wrote:
>>>> On Wed, Oct 10, 2018 at 11:17 AM Josh Poimboeuf <jpoimboe@...hat.com> wrote:
>>>> 
>>>>> On Wed, Oct 10, 2018 at 01:16:05PM -0500, Josh Poimboeuf wrote:
>>>>> On Wed, Oct 10, 2018 at 11:03:43AM -0700, Andy Lutomirski wrote:
>>>>>>> +#define DECLARE_STATIC_CALL(tramp, func)                               \
>>>>>>> +       extern typeof(func) tramp;                                      \
>>>>>>> +       static void __used __section(.discard.static_call_tramps)       \
>>>>>>> +               *__static_call_tramp_##tramp = tramp
>>>>>>> +
>>>>>> 
>>>>>> Confused.  What's the __static_call_tramp_##tramp variable for?  And
>>>>>> why is a DECLARE_ macro defining a variable?
>>>>> 
>>>>> This is the magic needed for objtool to find all the call sites.
>>>>> 
>>>>> The variable itself isn't needed, but the .discard.static_call_tramps
>>>>> entry is.  Objtool reads that section to find out which function call
>>>>> sites are targeted to a static call trampoline.
>>>> 
>>>> To clarify: objtool reads that section to find out which functions are
>>>> really static call trampolines.  Then it annotates all the instructions
>>>> which call/jmp to those trampolines.  Those annotations are then read by
>>>> the kernel.
>>>> 
>>> 
>>> Ah, right, and objtool runs on a per-object basis so it has no other
>>> way to know what symbols are actually static calls.
>>> 
>>> There's another way to skin this cat, though:
>>> 
>>> extern typeof(func) __static_call_trampoline_##tramp;
>>> #define tramp __static_call_trampoline_##tramp
>>> 
>>> And objtool could recognize it by name.  But, of course, you can't put
>>> a #define in a macro.  But maybe there's a way to hack it up with a
>>> static inline?
> 
> I went with something similar in the latest version.  It's less
> surprising in a couple of ways:
> 
> - DECLARE_STATIC_CALL doesn't have the magic objtool definition.
> 
> - Call sites use the static_call() wrapper, which makes static calls
>  clearly visible.

Seems reasonable. Also, for a real patch, it should be straightforward to have a fallback implementation in include/linux/static_call.h that just dereferences the pointer.