linux-kernel - Re: Question on FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec680438-babe-4ee7-988b-c2466a11e789@huawei.com>
Date:   Thu, 11 Oct 2018 18:26:12 +0100
From:   John Garry <john.garry@...wei.com>
To:     Johannes Berg <johannes@...solutions.net>,
        Joe Perches <joe@...ches.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        <jakub.kicinski@...ronome.com>, <yamada.masahiro@...ionext.com>,
        "Arnd Bergmann" <arnd@...db.de>, <viro@...iv.linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     <linux-wireless@...r.kernel.org>, <nbd@....name>
Subject: Re: Question on FIELD_PREP() for static array

>> Yeah, I have a patch now to reference it, but I don't see anything from
>> -Wvla with gcc 8.1?
>
> I'm using a 7.3.1-based toolchain
>
>>
>> See
>> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=3d7af878357acd9e37fc156928106f1a969c8942
>>
>> and its parent.
>>
>> Do you see -Wvla warnings there? Any idea how I could reproduce them?
>
> I'll try it, thanks

3d7af878357acd9e37f builds ok. However I am using 20181010-next (I'm not 
sure what yours is based on), and I just noticed that it includes this 
new guy:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/Makefile?h=next-20181011&id=bc5701d8e27fd8beaf895176982fc6a97878f3b8

When I cherry-pick this onto your codebase@...af878357acd9e37f, the 
82011 code has warns.

Thanks,
John


>
> John
>
>>
>> johannes
>>
>> .
>>
>