linux-kernel - Re: [RESEND][PATCH v2] cfq: clear queue pointers from cfqg after unpinning them in cfq_pd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3abb177f-d6ba-7f7b-e8a6-d27e8cf388a0@kernel.dk>
Date:   Thu, 11 Oct 2018 11:46:37 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:     Caspar Zhang <caspar@...ux.alibaba.com>,
        jiufei.xue@...ux.alibaba.com, Tejun Heo <tj@...nel.org>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org
Subject: Re: [RESEND][PATCH v2] cfq: clear queue pointers from cfqg after
 unpinning them in cfq_pd_offline

On 10/10/18 3:16 PM, Maciej S. Szmigiero wrote:
> BFQ is already doing a similar thing in its .pd_offline_fn() method
> implementation.
> 
> While it seems that after commit 4c6994806f70
> ("blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()")
> was reverted leaving these pointers intact no longer causes crashes
> clearing them is still a sensible thing to do to make the code more robust.

Applied, thanks.

-- 
Jens Axboe