linux-kernel - Re: [PATCH] r8169: set RX_MULTI_EN bit in RxConfig for 8168F-family chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181011.120839.321027152552999776.davem@davemloft.net>
Date:   Thu, 11 Oct 2018 12:08:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mail@...iej.szmigiero.name
Cc:     chris2553@...glemail.com, hkallweit1@...il.com,
        a3at.mail@...il.com, nic_swsd@...ltek.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8169: set RX_MULTI_EN bit in RxConfig for
 8168F-family chips

From: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Date: Thu, 11 Oct 2018 16:02:10 +0200

> It has been reported that since
> commit 05212ba8132b42 ("r8169: set RxConfig after tx/rx is enabled for RTL8169sb/8110sb devices")
> at least RTL_GIGA_MAC_VER_38 NICs work erratically after a resume from
> suspend.
> The problem has been traced to a missing RX_MULTI_EN bit in the RxConfig
> register.
> We already set this bit for RTL_GIGA_MAC_VER_35 NICs of the same 8168F
> chip family so let's do it also for its other siblings: RTL_GIGA_MAC_VER_36
> and RTL_GIGA_MAC_VER_38.
> 
> Curiously, the NIC seems to work fine after a system boot without having
> this bit set as long as the system isn't suspended and resumed.
> 
> Fixes: 05212ba8132b42 ("r8169: set RxConfig after tx/rx is enabled for RTL8169sb/8110sb devices")
> Reported-by: Chris Clayton <chris2553@...glemail.com>
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>

Applied and queued up for -stable.