lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Oct 2018 14:23:10 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Michael Schupikov <michael@...upikov.de> Cc: "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] crypto/testmgr.c: fix sizeof() on COMP_BUF_SIZE On Sun, Oct 07, 2018 at 01:58:10PM +0200, Michael Schupikov wrote: > After allocation, output and decomp_output both point to memory chunks of > size COMP_BUF_SIZE. Then, only the first bytes are zeroed out using > sizeof(COMP_BUF_SIZE) as parameter to memset(), because > sizeof(COMP_BUF_SIZE) provides the size of the constant and not the size of > allocated memory. > > Instead, the whole allocated memory is meant to be zeroed out. Use > COMP_BUF_SIZE as parameter to memset() directly in order to accomplish > this. > > Fixes: 336073840a872 ("crypto: testmgr - Allow different compression results") > > Signed-off-by: Michael Schupikov <michael@...upikov.de> > --- > crypto/testmgr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists