linux-kernel - Re: [driver-core PATCH v3 5/5] PM core: Use new async_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ioPTXP6L6TXvRHvHdTQFu-v74izHUYSDoc3b9gYS7wog@mail.gmail.com>
Date:   Fri, 12 Oct 2018 09:53:00 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     alexander.h.duyck@...ux.intel.com
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Len Brown <len.brown@...el.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Pavel Machek <pavel@....cz>, zwisler@...nel.org,
        Tejun Heo <tj@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [driver-core PATCH v3 5/5] PM core: Use new async_schedule_dev command

On Fri, Oct 12, 2018 at 12:10 AM Alexander Duyck
<alexander.h.duyck@...ux.intel.com> wrote:
>
> This change makes it so that we use the device specific version of the
> async_schedule commands to defer various tasks related to power management.
> By doing this we should see a slight improvement in performance as any
> device that is sensitive to latency/locality in the setup will now be
> initializing on the node closest to the device.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  drivers/base/power/main.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index a690fd400260..ebb8b61b52e9 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -726,7 +726,7 @@ void dpm_noirq_resume_devices(pm_message_t state)
>                 reinit_completion(&dev->power.completion);
>                 if (is_async(dev)) {
>                         get_device(dev);
> -                       async_schedule(async_resume_noirq, dev);
> +                       async_schedule_dev(async_resume_noirq, dev);
>                 }
>         }
>
> @@ -883,7 +883,7 @@ void dpm_resume_early(pm_message_t state)
>                 reinit_completion(&dev->power.completion);
>                 if (is_async(dev)) {
>                         get_device(dev);
> -                       async_schedule(async_resume_early, dev);
> +                       async_schedule_dev(async_resume_early, dev);
>                 }
>         }
>
> @@ -1047,7 +1047,7 @@ void dpm_resume(pm_message_t state)
>                 reinit_completion(&dev->power.completion);
>                 if (is_async(dev)) {
>                         get_device(dev);
> -                       async_schedule(async_resume, dev);
> +                       async_schedule_dev(async_resume, dev);
>                 }
>         }
>
> @@ -1366,7 +1366,7 @@ static int device_suspend_noirq(struct device *dev)
>
>         if (is_async(dev)) {
>                 get_device(dev);
> -               async_schedule(async_suspend_noirq, dev);
> +               async_schedule_dev(async_suspend_noirq, dev);
>                 return 0;
>         }
>         return __device_suspend_noirq(dev, pm_transition, false);
> @@ -1569,7 +1569,7 @@ static int device_suspend_late(struct device *dev)
>
>         if (is_async(dev)) {
>                 get_device(dev);
> -               async_schedule(async_suspend_late, dev);
> +               async_schedule_dev(async_suspend_late, dev);
>                 return 0;
>         }
>
> @@ -1833,7 +1833,7 @@ static int device_suspend(struct device *dev)
>
>         if (is_async(dev)) {
>                 get_device(dev);
> -               async_schedule(async_suspend, dev);
> +               async_schedule_dev(async_suspend, dev);
>                 return 0;
>         }
>
>