linux-kernel - Re: REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1539336896.30485.15.camel@toradex.com>
Date:   Fri, 12 Oct 2018 09:34:58 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>
CC:     "timur@...nel.org" <timur@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "jhugo@...eaurora.org" <jhugo@...eaurora.org>,
        "ricardo.ribalda@...il.com" <ricardo.ribalda@...il.com>
Subject: Re: REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from
 the beginning

On Fri, 2018-10-12 at 11:08 +0200, Linus Walleij wrote:
> On Fri, Oct 12, 2018 at 11:00 AM Marcel Ziswiler
> <marcel.ziswiler@...adex.com> wrote:
> > On Fri, 2018-10-05 at 08:53 +0200, Ricardo Ribalda Delgado wrote:
> > > Current code assumes that the direction is input if
> > > direction_input
> > > function is set.
> > > This might not be the case on GPIOs with programmable direction.
> > 
> > Unfortunately, this breaks at least Apalis T30 and Apalis TK1.
> > Enabling
> > earlycon reveals the following:
> 
> Does this (just applied) patch fix the issue?
> https://marc.info/?l=linux-kernel&m=153932470412013&w=2

Yes, that cuts it. Thanks!

> Yours,
> Linus Walleij