linux-kernel - Re: [PATCH] printk: fix integer overflow in setup_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181012103324.gsczzzf4wiaq5tfm@pathway.suse.cz>
Date:   Fri, 12 Oct 2018 12:33:24 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: fix integer overflow in setup_log_buf()

On Fri 2018-10-12 18:27:24, Sergey Senozhatsky wrote:
> On (10/12/18 11:01), Petr Mladek wrote:
> > > Make "free" unsigned integer and use appropriate printk() specifier.
> > > 
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > 
> > I have pushed this fix into printk.git, for-4.20 branch.
> 
> Thanks.
> 
> > Please note that this 2nd hunk was already part of the commit
> > e6fe3e5b7d16e8f14 ("printk: Give error on attempt to set log
> > buffer length to over 2G"), see
> > https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.20&id=e6fe3e5b7d16e8f146a4ae7fe481bc6e97acde1e
> 
> Oh, indeed. I guess I used linux-next which didn't have your commit.

Yeah, I forgot to push some recent changes for linux-next.

Best Regards,
Petr