linux-kernel - Re: [PATCH] afs: Fix cell proc list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181012113134.GA22324@kroah.com>
Date:   Fri, 12 Oct 2018 13:31:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     David Howells <dhowells@...hat.com>
Cc:     torvalds@...ux-foundation.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] afs: Fix cell proc list

On Thu, Oct 11, 2018 at 10:45:49PM +0100, David Howells wrote:
> Access to the list of cells by /proc/net/afs/cells has a couple of
> problems:
> 
>  (1) It should be checking against SEQ_START_TOKEN for the keying the
>      header line.
> 
>  (2) It's only holding the RCU read lock, so it can't just walk over the
>      list without following the proper RCU methods.
> 
> Fix these by using an hlist instead of an ordinary list and using the
> appropriate accessor functions to follow it with RCU.
> 
> Since the code that adds a cell to the list must also necessarily change,
> sort the list on insertion whilst we're at it.
> 
> Fixes: 989782dcdc91 ("afs: Overhaul cell database management")
> Signed-off-by: David Howells <dhowells@...hat.com>

Now applied, thanks.

greg k-h