linux-kernel - Re: [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0184EA26B2509940AA629AE1405DD7F201ECC805@dggema523-mbx.china.huawei.com>
Date:   Fri, 12 Oct 2018 15:36:14 +0000
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     James Morse <james.morse@....com>
CC:     "christoffer.dall@....com" <christoffer.dall@....com>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "peter.maydell@...aro.org" <peter.maydell@...aro.org>,
        "drjones@...hat.com" <drjones@...hat.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events
 support

Hi James,

> Hi Dongjiu Geng,
> 
> On 11/10/2018 20:07, Dongjiu Geng wrote:
> > The commit 539aee0edb9f ("KVM: arm64: Share the parts of get/set
> > events useful to 32bit") shares the get/set events helper for arm64
> > and arm32,
> 
> Oops. I evidently didn't test this bit. Looks like I just depended on the symbol to be defined, I didn't check the CAP was exposed.

Yes, you do not check the CAP when you test it.

> 
> 
> > it is better also share the check
> > for vcpu events capability to enable 32 bit kvm vcpu events support.
> 
> not just better, necessary for correctly-written user-space to know the feature is supported. This last bit would be clearer as: "but forgot to
> share the cap extension code."

Ok, will update it.

> 
> 
> Thanks for catching this!

You are welcome

> 
> Acked-by: James Morse <james.morse@....com>
> 
> 
> Thanks,
> 
> James