linux-kernel - Re: [PATCH] afs: Fix afs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181012153719.GA25689@kroah.com>
Date:   Fri, 12 Oct 2018 17:37:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     David Howells <dhowells@...hat.com>
Cc:     torvalds@...ux-foundation.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] afs: Fix afs_server struct leak

On Fri, Oct 12, 2018 at 02:00:57PM +0100, David Howells wrote:
> Fix a leak of afs_server structs.  The routine that installs them in the
> various lookup lists and trees gets a ref on leaving the function, whether
> it added the server or a server already exists.  It shouldn't increment
> the refcount if it added the server.
> 
> The effect of this that "rmmod kafs" will hang waiting for the leaked
> server to become unused.
> 
> Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation")
> Signed-off-by: David Howells <dhowells@...hat.com>

Now applied, thanks.

greg k-h