linux-kernel - Re: [PATCH 3.18 000/120] 3.18.124-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181012153916.GA13257@roeck-us.net>
Date:   Fri, 12 Oct 2018 08:39:16 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
        ben.hutchings@...ethink.co.uk, lkft-triage@...ts.linaro.org,
        stable@...r.kernel.org
Subject: Re: [PATCH 3.18 000/120] 3.18.124-stable review

On Fri, Oct 12, 2018 at 08:15:06AM -0700, Guenter Roeck wrote:
> On Fri, Oct 12, 2018 at 04:21:10PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 12, 2018 at 07:06:13AM -0700, Guenter Roeck wrote:
> > > On 10/12/2018 06:37 AM, Greg Kroah-Hartman wrote:
> > > > On Fri, Oct 12, 2018 at 05:19:16AM -0700, Guenter Roeck wrote:
> > > > > On 10/11/2018 08:33 AM, Greg Kroah-Hartman wrote:
> > > > > > This is the start of the stable review cycle for the 3.18.124 release.
> > > > > > There are 120 patches in this series, all will be posted as a response
> > > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > > 
> > > > > > Responses should be made by Sat Oct 13 15:25:29 UTC 2018.
> > > > > > Anything received after that time might be too late.
> > > > > > 
> > > > > 
> > > > > [preliminary]
> > > > > 
> > > > > arm:allmodconfig:
> > > > > 
> > > > > drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_init_lut':
> > > > > drivers/mtd/spi-nor/fsl-quadspi.c:170:5: error: 'LUT_0' undeclared
> > > > 
> > > > That is really odd in that there are no patches that touch this file,
> > > > and I do not even see "LUT_0" anywhere in the 3.18.y tree.
> > > > 
> > > 
> > > Bisect:
> > > 
> > > 
> > > # bad: [8c4ca12b60ea371a32db58cf78b6cb4e2ba4515c] Linux 3.18.124-rc1
> > > # good: [921b2fed6a79439ef1609ef4af0ada5cccb3555c] Linux 3.18.123
> > > git bisect start 'HEAD' 'v3.18.123'
> > > # good: [aed5b0190528303a3f4d319f95d7e38c94ca32ab] USB: remove LPM management from usb_driver_claim_interface()
> > > git bisect good aed5b0190528303a3f4d319f95d7e38c94ca32ab
> > > # good: [10441f560c0ad0aeed00402088d71d4d299d6537] r8169: Clear RTL_FLAG_TASK_*_PENDING when clearing RTL_FLAG_TASK_ENABLED
> > > git bisect good 10441f560c0ad0aeed00402088d71d4d299d6537
> > > # bad: [0661a919177560337d962f43daa46dde2fa4d89e] mac80211: fix setting IEEE80211_KEY_FLAG_RX_MGMT for AP mode keys
> > > git bisect bad 0661a919177560337d962f43daa46dde2fa4d89e
> > > # good: [d4b130cc92bbef445de4ffe4ecd068935375d591] ocfs2: fix locking for res->tracking and dlm->tracking_list
> > > git bisect good d4b130cc92bbef445de4ffe4ecd068935375d591
> > > # bad: [1f002a3e6d7250a62966399bd91eeec308c0b756] fbdev/omapfb: fix omapfb_memory_read infoleak
> > > git bisect bad 1f002a3e6d7250a62966399bd91eeec308c0b756
> > > # bad: [5396a79f029d54c1e02409335c7dfde43c55e4a4] Make file credentials available to the seqfile interfaces
> > > git bisect bad 5396a79f029d54c1e02409335c7dfde43c55e4a4
> > > # good: [7da4d144b6922e94aad8c0d405e4cc63a44b8ec5] dm thin metadata: fix __udivdi3 undefined on 32-bit
> > > git bisect good 7da4d144b6922e94aad8c0d405e4cc63a44b8ec5
> > > # first bad commit: [5396a79f029d54c1e02409335c7dfde43c55e4a4] Make file credentials available to the seqfile interfaces
> > > 
> > > ... and reverting that patch fixes the problem. No idea why; maybe because of include
> > > file changes.
> > 
> > That patch _adds_ two .h files to be included in
> > include/linux/seq_file.h, not removes any.
> > 
> > Ugh, that's a mess.
> > 
> > I've seen the LUT_0 thing show up a long time ago due to some other odd
> > arm thing.  But I don't remember how it was ever resolved.  Maybe I'll
> > just let this one go and see if anyone notices :)
> > 
> See commit 04850c4d8613127a9b488321c0ad83bff7519311. I'll check if it applies
> and fixes the problem, and let you know.
> 
I confirmed that commit 04850c4d86131 applies and fixes the problem.

Guenter