linux-kernel - Re: usbnet private-data accessor functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1539358728.2802.3.camel@suse.com>
Date:   Fri, 12 Oct 2018 17:38:48 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     gregkh@...uxfoundation.org, linux-kernel@...ts.codethink.co.uk,
        bjorn@...k.no, steve.glendinning@...well.net,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: usbnet private-data accessor functions

On Fr, 2018-10-12 at 10:16 +0100, Ben Dooks wrote:
> I have been looking at the usbnet drivers and the possibility of some
> code cleanups. One of the things I've found is that changing the way
> the drivers use the private data with the usbnet structure is often
> hand-coded each time is needed.

Where is the improvement? You are just hiding how the data is passed.
It may look more pleasant to you, but that is a subjective impression.
I would suggest that if you want a nicely named way to get at private
data, add a field to the appropriate data structure.

	Regards
		Oliver