linux-kernel - Re: [PATCHv5 3/7] tty: Hold tty_ldisc_lock() during tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1539359857.2706.23.camel@arista.com>
Date:   Fri, 12 Oct 2018 16:57:37 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     Guilherme Piccoli <gpiccoli@...onical.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCHv5 3/7] tty: Hold tty_ldisc_lock() during tty_reopen()

Hi Guilherme,

Just to let you know - I've done with more urgent issues now,
so I'll be back on this patch on Monday, installing qemu-system-hppa
and debugging the root case.

Thanks,
Dmitry

On Wed, 2018-10-03 at 07:46 -0300, Guilherme Piccoli wrote:
> On Tue, Oct 2, 2018 at 6:33 PM Dmitry Safonov <dima@...sta.com>
> wrote:
> > [...]
> > Well, v5 passes 0day, so all previous reports are fixed.
> > But there is a new one about reboot on parisc platform which takes
> > ~3
> > mins after the patch with ldisc locked on tty_reopen().
> > 
> > I believe it's related to holding read side for too long..
> > So, the patches still need another fix, heh.
> > 
> > Unfortunately, I was a bit busy with other bugs hitting more in
> > Arista.
> 
> Hi Dmitry, thank you! Yeah, I saw that reading the whole thread after
> sending this email heheh
> That's a bummer =/
> 
> Unfortunately, I don't have a reproducer to exercise your patch. Do
> you
> have some recipe on how to reproduce it easily?
> I'll try more, in order I can validate the reboot behavior here.
> 
> 
> > > > I'd like to ask you if you did respin the patch with Greg's
> > > > suggestion
> > > > for the tag - I couldn't find it in LKML heheh
> > > > 
> > > > Oh, if you can CC me in future spins of this patch (in case
> > > > there
> > > > any),
> > > > I'd really be glad.
> > 
> > Sure, will enlarge Cc list ;)
> > 
> 
> Thanks again!
> Cheers,
> 
> 
> Guilherme