linux-kernel - [PATCH] block/sx8 : remove unnecessory check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1539361453-3383-1-git-send-email-penghao122@sina.com.cn>
Date:   Fri, 12 Oct 2018 12:24:13 -0400
From:   Peng Hao <penghao122@...a.com.cn>
To:     axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Peng Hao <peng.hao2@....com.cn>
Subject: [PATCH]  block/sx8 : remove unnecessory check


From: Peng Hao <peng.hao2@....com.cn>

TAG_VALID(tag)= ((((tag) & 0xf) == 0xf) && (TAG_DECODE(tag) < 32)).
But '(X & 0x1f) < 0x20(32)' is always true. The second half of
TAG_VALID is unnecessary.

Signed-off-by: Peng Hao <peng.hao2@....com.cn>
---
 drivers/block/sx8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/sx8.c b/drivers/block/sx8.c
index 4d90e5e..b8e9ebf 100644
--- a/drivers/block/sx8.c
+++ b/drivers/block/sx8.c
@@ -75,7 +75,7 @@
 /* 0xf is just arbitrary, non-zero noise; this is sorta like poisoning */
 #define TAG_ENCODE(tag)	(((tag) << 16) | 0xf)
 #define TAG_DECODE(tag)	(((tag) >> 16) & 0x1f)
-#define TAG_VALID(tag)	((((tag) & 0xf) == 0xf) && (TAG_DECODE(tag) < 32))
+#define TAG_VALID(tag)	(((tag) & 0xf) == 0xf)
 
 /* note: prints function name for you */
 #ifdef CARM_DEBUG
-- 
1.8.3.1