linux-kernel - Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181012165751.GI2340@sirena.org.uk>
Date:   Fri, 12 Oct 2018 18:57:51 +0200
From:   Mark Brown <broonie@...nel.org>
To:     Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robert.jarzmik@...e.fr" <robert.jarzmik@...e.fr>,
        "aaro.koskinen@....fi" <aaro.koskinen@....fi>,
        "jacopo@...ndi.org" <jacopo@...ndi.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        "shc_work@...l.ru" <shc_work@...l.ru>,
        "haojian.zhuang@...il.com" <haojian.zhuang@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "rppt@...ux.vnet.ibm.com" <rppt@...ux.vnet.ibm.com>,
        "zonque@...il.com" <zonque@...il.com>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        "philipp.zabel@...il.com" <philipp.zabel@...il.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "jmkrzyszt@...il.com" <jmkrzyszt@...il.com>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>
Subject: Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

On Fri, Oct 12, 2018 at 11:43:13AM +0000, Marcel Ziswiler wrote:
> On Fri, 2018-10-12 at 11:43 +0100, Russell King - ARM Linux wrote:

> > The existing DT description is reasonable, and introducing ficticious
> > regulators in DT to work around the implementation is not reasonable.

> I don't think it is that fictitious as it makes it crystal clear that
> there is something shared with all its pros and cons. E.g. what happens
> if one of them regulators wants to turn off while the other one still
> needs power? The regular regulator dependency tree would nicely make
> this all clear.

We already have code to handle that via refcounting on the GPIO once we
identify that it's the same GPIO.  If we make a shared virtual parent
regulator that'll break other things where we're tracking what the
actual physical parent for voltage reasons like adjusting parent
voltages up and down to improve efficiency or handling things that are
just dumb power switches rather than actual regulators.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)