lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Oct 2018 10:58:04 -0600 From: Keith Busch <keith.busch@...el.com> To: Dan Williams <dan.j.williams@...el.com> Cc: "Kirill A. Shutemov" <kirill@...temov.name>, Linux MM <linux-mm@...ck.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Dave Hansen <dave.hansen@...el.com>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCHv2] mm/gup: Cache dev_pagemap while pinning pages On Fri, Oct 12, 2018 at 09:58:18AM -0700, Dan Williams wrote: > On Fri, Oct 12, 2018 at 4:00 AM Kirill A. Shutemov <kirill@...temov.name> wrote: > [..] > > > Does this have defined behavior? I would feel better with " = { 0 }" > > > to be explicit. > > > > Well, it's not allowed by the standart, but GCC allows this. > > You can see a warning with -pedantic. > > > > We use empty-list initializers a lot in the kernel: > > $ git grep 'struct .*= {};' | wc -l > > 997 > > > > It should be fine. > > Ah, ok. I would still say we should be consistent between the init > syntax for 'ctx' in follow_page() and __get_user_pages(), and why not > go with '= { 0 }', one less unnecessary gcc'ism. No problem, I'll make that happen and copy your reviews/acks into the next patch.
Powered by blists - more mailing lists