linux-kernel - Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UJsBz1-tVyX2uChoKVrb54W3JD-3rCoCyhVcbuuXi0Gw@mail.gmail.com>
Date:   Fri, 12 Oct 2018 10:17:17 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Manu Gautam <mgautam@...eaurora.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Evan Green <evgreen@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value
 for SDM845

Hi,

On Thu, Oct 11, 2018 at 10:57 PM <mgautam@...eaurora.org> wrote:
> Fused value is supposed to always override. If value is not fused for
> some
> parts (which I believe is case with some early samples), then driver
> will
> read it is '0' from nvmem and should use hstx-trim value passed from DT.

OK cool.  Just wanted to make sure.  ...so the fusing must be written
after the SoC is placed on a board.  I wonder if it makes sense to
document this in a comment so I don't ask about it again.  ;-)

In any case, once you've got the patch split in 2 (and added the
"Fixes" tag to each patch) feel free to add my Reviewed-by tag to each
patch.

-Doug