linux-kernel - Re: [PATCH v4 1/2] arm64: dts: allwinner: new board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181012202330.tdwedsof2bsnxkxn@flea>
Date:   Fri, 12 Oct 2018 22:23:30 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Aleksandr Aleksandrov <aleksandr.aleksandrov@...id.com>
Cc:     Andreas Färber <afaerber@...e.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chen-Yu Tsai <wens@...e.org>,
        David Lechner <david@...hnology.com>,
        Thierry Reding <treding@...dia.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Johan Hovold <johan@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 1/2] arm64: dts: allwinner: new board - Emlid Neutis N5

On Fri, Oct 12, 2018 at 04:39:14PM +0300, Aleksandr Aleksandrov wrote:
> Hi Andreas,
> 
> Thanks for your feedback!
> 
> > > + *
> > > + * Copyright (C) 2018 Aleksandr Aleksandrov <aleksandr.aleksandrov@...id.com>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "sun50i-h5-emlid-neutis-n5.dtsi"
> > > +
> > > +/ {
> > > +	model = "Emlid Neutis N5 Developer board";
> > > +	compatible = "emlid,neutis-n5-devboard",
> > > +		     "emlid,neutis-n5",
> > 
> > You are lacking bindings definitions for these new identifiers. The
> > vendor prefix should be patch 1/3, the SoM/board compatibles 2/3 and
> > this .dts[i] patch 3/3, so that only vendor prefixes and compatibles
> > that are defined and don't result in checkpatch.pl warnings get used.
> 
> Patch 2/3:
> 
> commit 46dcb8632b36644cb20e6b35ede12ff0088a60eb
> Author: Aleksandr Aleksandrov <aleksandr.aleksandrov@...id.com>
> Date:   Fri Oct 12 16:22:28 2018 +0300
> 
>     dt-bindings: arm: sunxi: emlid,neutis-n5(-devboard)
>     
>     sunxi: add new compatibles for Emlid Neutis Dev board and SoM module
>     
>     Signed-off-by: Aleksandr Aleksandrov <aleksandr.aleksandrov@...id.com>
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt
> index e4beec3..a907e52 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.txt
> +++ b/Documentation/devicetree/bindings/arm/sunxi.txt
> @@ -19,3 +19,5 @@ using one of the following compatible strings:
>    allwinner,sun9i-a80
>    allwinner,sun50i-a64
>    nextthing,gr8
> +  emlid,neutis-n5
> +  emlid,neutis-n5-devboard
> 
> Is this right place for the neutis compatibles?

No, those are for SoCs compatible. I'm not sure we ever created a
board compatible files.

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com