[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181013075212.GA23437@infradead.org>
Date: Sat, 13 Oct 2018 00:52:12 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Finn Thain <fthain@...egraphics.com.au>
Cc: Christoph Hellwig <hch@...radead.org>,
"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Michael Schmitz <schmitzmic@...il.com>,
Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org,
linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] esp_scsi: De-duplicate PIO routines
On Sat, Oct 13, 2018 at 06:22:18PM +1100, Finn Thain wrote:
> > > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS));
> >
> > This should probably use dev_err (at least with my series).
> >
>
> How about shost_printk()? That would be consistent with the rest of
> esp_scsi.c. It also means my series need not depend on yours which would
> complicate things.
Yes, that sounds even better.
Powered by blists - more mailing lists