linux-kernel - Re: ubifs: WARNINGs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvxEP+j07s8gnVw9DiJZeedxgrk1xtEkaXAMvkfa9HHvCw@mail.gmail.com>
Date:   Sat, 13 Oct 2018 10:21:41 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "linux-mtd @ lists . infradead . org" <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: ubifs: WARNINGs

Randy,

On Sat, Oct 13, 2018 at 3:48 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Hi,
>
> Linux 4.19-rc7, x86_64 laptop.
>
> I don't have an ubifs filesystem.  When I just modprobe ubifs and then
> rmmod ubifs, I get 2 WARNINGs from these 2 lines:
>
> static void __exit ubifs_exit(void)
> {
>         WARN_ON(list_empty(&ubifs_infos));
>         WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0);
>
> Is this normal/expected?

Nah, in -rc1 I rewrote all UBIFS assert code and these two are a corner case.
I've messed up the logic, ubifs_assert(exp) is WARN_ON(!exp).
Patch sent, would be great if you could give it a try.

-- 
Thanks,
//richard