linux-kernel - Re: Bug introduced in the of_get_named_gpiod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaeBMc-wqZxh0vVXRiRMvTHDFXxOk0aaxN=swcnLBhG5w@mail.gmail.com>
Date:   Sat, 13 Oct 2018 18:23:50 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     wzabolot@...ktron.elka.pw.edu.pl
Cc:     Michal Simek <michal.simek@...inx.com>, wzab@....pw.edu.pl,
        Randy Dunlap <rdunlap@...radead.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Bug introduced in the of_get_named_gpiod_flags function.

On Sat, Oct 13, 2018 at 5:53 PM wzabolot@...ktron.elka.pw.edu.pl
<wzabolot@...ktron.elka.pw.edu.pl> wrote:

> The question is, if there may be any other in-tree GPIO controller
> driver that does not initialize those flags?

So as I said, I looked over them and they all initialize
their flags.

> Anyway the current situation is somehow dangerous.

Not very dangerous compared to much other kernel code.

> Maybe the best solution would be to initialize the automatic variable in
> the of_find_gpio?

Patches welcom, make sure they are tested with mainline
code and drivers.

Yours.
Linus Walleij