linux-kernel - Re: [PATCH] ath10k: remove unnecessary comparison of unsigned integer with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181013172421.98A3C60A98@smtp.codeaurora.org>
Date:   Sat, 13 Oct 2018 17:24:21 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH] ath10k: remove unnecessary comparison of unsigned integer
 with < 0

"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

> There is no need to compare *ps_state_enable* with < 0 because
> such variable is of type u8 (8 bits, unsigned), making it
> impossible to hold a negative value.
> 
> Fix this by removing such comparison.
> 
> Addresses-Coverity-ID: 1473921 ("Unsigned compared against 0")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

7bfd82bff60e ath10k: remove unnecessary comparison of unsigned integer with < 0

-- 
https://patchwork.kernel.org/patch/10628679/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches