linux-kernel - Re: [PATCH V2 0/2] blk-mq: some fixes about updating hw queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d50f599-4243-6a11-b7d0-9eee9d71ec63@kernel.dk>
Date:   Sat, 13 Oct 2018 16:51:44 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Jianchao Wang <jianchao.w.wang@...cle.com>
Cc:     keith.busch@...ux.intel.com, ming.lei@...hat.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 0/2] blk-mq: some fixes about updating hw queues

On 10/12/18 4:07 AM, Jianchao Wang wrote:
> Hi Jens
> 
> This patch set fixes some defects during update hw queues.
> 
> 1st patch refactor the blk-mq debugfs and sysfs register during
> blk_mq_update_nr_hw_queues.
> 
> 2nd patch change the GFP_KERNEL to GFP_NOIO during blk_mq_realloc_hw_ctxs,
> 
> 3rd patch try to realloc hctx when this hctx is mapped to a different node.
> 
> 4th patch should be able to fix the panic reported in follwing link
> https://marc.info/?l=linux-block&m=153799465603723&w=2
> 
> V2:
>  - Newly add 2nd and 3rd patch.
>  - Use blk_mq_map_queues when __blk_mq_update_nr_hw_queues fallbacks to
>    previous nr_hw_queues to avoid driver's .map_queues leak mapping of
>    some cpus due the fallback nr_hw_queues.
>  - Add Ming's Reviewed-by in 1st patch.
> 
> 
> Jianchao Wang[4]
> blk-mq: adjust debugfs and sysfs register when
> blk-mq: change gfp flags to GFP_NOIO in
> blk-mq: realloc hctx when hw queue is mapped to
> blk-mq: fallback to previous nr_hw_queues when
> 
>  block/blk-core.c  |   2 +-
>  block/blk-flush.c |   6 +--
>  block/blk-mq.c    | 155 ++++++++++++++++++++++++++++++++++--------------------
>  block/blk.h       |   2 +-
>  4 files changed, 102 insertions(+), 63 deletions(-)
> 

Applied, thanks.

-- 
Jens Axboe