linux-kernel - Re: [PATCH] docs: Fix typos in histogram.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181012220452.57d23a82@vmware.local.home>
Date:   Fri, 12 Oct 2018 22:04:52 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masanari Iida <standby24x7@...il.com>
Cc:     corbet@....net, linux-kernel@...r.kernel.org,
        mchehab+samsung@...nel.org,
        Tom Zanussi <tom.zanussi@...ux.intel.com>
Subject: Re: [PATCH] docs: Fix typos in histogram.rst

On Sat, 13 Oct 2018 10:30:57 +0900
Masanari Iida <standby24x7@...il.com> wrote:

> This patch fixes some spelling typos.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
>  Documentation/trace/histogram.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> index 5ac724baea7d..7dda76503127 100644
> --- a/Documentation/trace/histogram.rst
> +++ b/Documentation/trace/histogram.rst
> @@ -1765,7 +1765,7 @@ For example, here's how a latency can be calculated::
>    # echo 'hist:keys=pid,prio:ts0=common_timestamp ...' >> event1/trigger
>    # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp-$ts0 ...' >> event2/trigger
>  
> -In the first line above, the event's timetamp is saved into the
> +In the first line above, the event's timestamp is saved into the
>  variable ts0.  In the next line, ts0 is subtracted from the second
>  event's timestamp to produce the latency, which is then assigned into
>  yet another variable, 'wakeup_lat'.  The hist trigger below in turn
> @@ -1811,7 +1811,7 @@ the command that defined it with a '!'::
>      /sys/kernel/debug/tracing/synthetic_events
>  
>  At this point, there isn't yet an actual 'wakeup_latency' event
> -instantiated in the event subsytem - for this to happen, a 'hist
> +instantiated in the event subsystem - for this to happen, a 'hist

The first two appear to show that Tom has a faulty 's' key ;-)

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve



>  trigger action' needs to be instantiated and bound to actual fields
>  and variables defined on other events (see Section 2.2.3 below on
>  how that is done using hist trigger 'onmatch' action). Once that is
> @@ -1837,7 +1837,7 @@ output can be displayed by reading the event's 'hist' file.
>  A hist trigger 'action' is a function that's executed whenever a
>  histogram entry is added or updated.
>  
> -The default 'action' if no special function is explicity specified is
> +The default 'action' if no special function is explicitly specified is
>  as it always has been, to simply update the set of values associated
>  with an entry.  Some applications, however, may want to perform
>  additional actions at that point, such as generate another event, or