linux-kernel - Re: [PATCH for 4.19] tracepoint: Fix: out-of-bound tracepoint array iteration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Oct 2018 10:08:45 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:     kbuild-all@...org, Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Ingo Molnar <mingo@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Catalin Marinas <catalin.marinas@....com>,
        James Morris <james.morris@...rosoft.com>,
        James Morris <jmorris@...ei.org>, Jessica Yu <jeyu@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Nicolas Pitre <nico@...aro.org>,
        Paul Mackerras <paulus@...ba.org>,
        Petr Mladek <pmladek@...e.com>,
        Russell King <linux@...linux.org.uk>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Thomas Garnier <thgarnie@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Will Deacon <will.deacon@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH for 4.19] tracepoint: Fix: out-of-bound tracepoint array
 iteration

Hi Mathieu,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mathieu-Desnoyers/tracepoint-Fix-out-of-bound-tracepoint-array-iteration/20181013-073410
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   In file included from drivers/media/media-devnode.c:33:0:
>> include/linux/module.h:433:2: error: unknown type name 'tracepoint_ptr_t'
     tracepoint_ptr_t *tracepoints_ptrs;
     ^~~~~~~~~~~~~~~~

vim +/tracepoint_ptr_t +433 include/linux/module.h

   430	
   431	#ifdef CONFIG_TRACEPOINTS
   432		unsigned int num_tracepoints;
 > 433		tracepoint_ptr_t *tracepoints_ptrs;
   434	#endif
   435	#ifdef HAVE_JUMP_LABEL
   436		struct jump_entry *jump_entries;
   437		unsigned int num_jump_entries;
   438	#endif
   439	#ifdef CONFIG_TRACING
   440		unsigned int num_trace_bprintk_fmt;
   441		const char **trace_bprintk_fmt_start;
   442	#endif
   443	#ifdef CONFIG_EVENT_TRACING
   444		struct trace_event_call **trace_events;
   445		unsigned int num_trace_events;
   446		struct trace_eval_map **trace_evals;
   447		unsigned int num_trace_evals;
   448	#endif
   449	#ifdef CONFIG_FTRACE_MCOUNT_RECORD
   450		unsigned int num_ftrace_callsites;
   451		unsigned long *ftrace_callsites;
   452	#endif
   453	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (66613 bytes)